| From: |
| Rob Clark <robdclark-AT-gmail.com> |
| To: |
| dri-devel-AT-lists.freedesktop.org |
| Subject: |
| [PATCH v3 0/9] drm: fdinfo memory stats |
| Date: |
| Mon, 01 May 2023 11:44:46 -0700 |
| Message-ID: |
| <20230501184502.1620335-1-robdclark@gmail.com> |
| Cc: |
| freedreno-AT-lists.freedesktop.org, Daniel Vetter <daniel-AT-ffwll.ch>, Tvrtko Ursulin <tvrtko.ursulin-AT-linux.intel.com>, Boris Brezillon <boris.brezillon-AT-collabora.com>, Christopher Healy <healych-AT-amazon.com>, Emil Velikov <emil.l.velikov-AT-gmail.com>, Christian König <christian.koenig-AT-amd.com>, Rob Clark <robdclark-AT-chromium.org>, Akhil P Oommen <quic_akhilpo-AT-quicinc.com>, Alex Deucher <alexander.deucher-AT-amd.com>, amd-gfx-AT-lists.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS), Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam-AT-amd.com>, Chia-I Wu <olvaffe-AT-gmail.com>, Dmitry Baryshkov <dmitry.baryshkov-AT-linaro.org>, Elliot Berman <quic_eberman-AT-quicinc.com>, Guchun Chen <guchun.chen-AT-amd.com>, Hawking Zhang <Hawking.Zhang-AT-amd.com>, Jim Cromie <jim.cromie-AT-gmail.com>, Konrad Dybcio <konrad.dybcio-AT-linaro.org>, linux-arm-msm-AT-vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-doc-AT-vger.kernel.org (open list:DOCUMENTATION), linux-kernel-AT-vger.kernel.org (open list), Marek Olšák <marek.olsak-AT-amd.com>, Mario Limonciello <mario.limonciello-AT-amd.com>, Maximilian Luz <luzmaximilian-AT-gmail.com>, Michel Dänzer <mdaenzer-AT-redhat.com>, Sean Paul <sean-AT-poorly.run>, Shashank Sharma <shashank.sharma-AT-amd.com>, Tvrtko Ursulin <tvrtko.ursulin-AT-intel.com>, YiPeng Chai <YiPeng.Chai-AT-amd.com> |
| Archive-link: |
| Article |
From: Rob Clark <robdclark@chromium.org>
Similar motivation to other similar recent attempt[1]. But with an
attempt to have some shared code for this. As well as documentation.
It is probably a bit UMA-centric, I guess devices with VRAM might want
some placement stats as well. But this seems like a reasonable start.
Basic gputop support: https://patchwork.freedesktop.org/series/116236/
And already nvtop support: https://github.com/Syllo/nvtop/pull/204
I've combined the separate series to add comm/cmdline override onto
the end of this, simply out of convenience (they would otherwise
conflict in a bunch of places).
v2: Extend things to allow for multiple regions other than just system
"memory", make drm_show_memory_stats() a helper so that, drivers
can use it or not based on their needs (but in either case, re-
use drm_print_memory_stats()
v3: Docs fixes
[1] https://patchwork.freedesktop.org/series/112397/
Rob Clark (9):
drm/docs: Fix usage stats typos
drm: Add common fdinfo helper
drm/msm: Switch to fdinfo helper
drm/amdgpu: Switch to fdinfo helper
drm: Add fdinfo memory stats
drm/msm: Add memory stats to fdinfo
drm/doc: Relax fdinfo string constraints
drm/fdinfo: Add comm/cmdline override fields
drm/msm: Wire up comm/cmdline override for fdinfo
Documentation/gpu/drm-usage-stats.rst | 101 ++++++++++----
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +-
drivers/gpu/drm/drm_file.c | 147 +++++++++++++++++++++
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 24 +++-
drivers/gpu/drm/msm/msm_drv.c | 15 ++-
drivers/gpu/drm/msm/msm_gem.c | 15 +++
drivers/gpu/drm/msm/msm_gpu.c | 2 -
drivers/gpu/drm/msm/msm_gpu.h | 10 ++
include/drm/drm_drv.h | 7 +
include/drm/drm_file.h | 51 +++++++
include/drm/drm_gem.h | 30 +++++
13 files changed, 376 insertions(+), 47 deletions(-)
--
2.39.2